----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127187/#review92814 -----------------------------------------------------------
src/lib/activitiesmodel.h (line 96) <https://git.reviewboard.kde.org/r/127187/#comment63238> Wouldn't it be better to use _MSC_VER <= 1800 /* MSVC2013 */ as maybe it works for MSVC2015? - Dāvis Mosāns On Feb. 26, 2016, 11:32 a.m., Thomas Friedrichsmeier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127187/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2016, 11:32 a.m.) > > > Review request for KDE Frameworks, kdewin and Ivan Čukić. > > > Repository: kactivities > > > Description > ------- > > MSVC (2013) complains that beginResetModel(), etc. are protected. This patch > allows the code to compile. It is clearly not very elegant, but both my > templating- and MSVC-foo is extremely limited. Not sure, if there is a better > fix. > > > Diffs > ----- > > src/lib/activitiesmodel.h 7258b73 > > Diff: https://git.reviewboard.kde.org/r/127187/diff/ > > > Testing > ------- > > Now compiles with MSVC 2013 on Windows. > > > Thanks, > > Thomas Friedrichsmeier > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel