> On Feb. 29, 2016, 2:15 p.m., Ivan Čukić wrote: > > Can you check the latest master - whether it builds - I've removed > > model_updaters from the ActivitiesModel. > > > > I have to say that I really hate MSVC...
Yes, latest master builds unmodified. Thanks. Closing. > I have to say that I really hate MSVC... I decidedly do not disagree... (But it appears Qt is determined to force it on us in the mid term, by way of QtWebEngine, which does not support compilation using MinGW.) - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127187/#review92909 ----------------------------------------------------------- On Feb. 29, 2016, 1:54 p.m., Thomas Friedrichsmeier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127187/ > ----------------------------------------------------------- > > (Updated Feb. 29, 2016, 1:54 p.m.) > > > Review request for KDE Frameworks, kdewin and Ivan Čukić. > > > Repository: kactivities > > > Description > ------- > > MSVC (2013) complains that beginResetModel(), etc. are protected. This patch > allows the code to compile. It is clearly not very elegant, but both my > templating- and MSVC-foo is extremely limited. Not sure, if there is a better > fix. > > > Diffs > ----- > > src/lib/activitiesmodel.h 7258b73 > src/lib/activitiesmodel.cpp af30f59 > src/lib/activitiesmodel_p.h dfa861b > src/utils/model_updaters.h ae8e279 > > Diff: https://git.reviewboard.kde.org/r/127187/diff/ > > > Testing > ------- > > Now compiles with MSVC 2013 on Windows. > > > Thanks, > > Thomas Friedrichsmeier > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
