> On Lis. 14, 2016, 10:32 odp., David Faure wrote: > > src/kdeinit/ktoolinvocation.cpp, line 107 > > <https://git.reviewboard.kde.org/r/129396/diff/2/?file=485446#file485446line107> > > > > Err that's a weird D-Bus name, isn't it? Should this become a > > freedesktop standard? > > Did you talk to hadess about it, before we make it a de-facto standard > > with a weird name? > > > > > > And then why not standardize the name of the key in the .desktop file > > while at it? > > > > x...@freedesktop.org is where to discuss both.
I sent him an email and he responded that he is not interested in making this a standard and doesn't consider this as a weird name. If the name changes in future I hope they will at least keep the old service name for backward compatibility, meanwhile I guess we have to keep this name. - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129396/#review100845 ----------------------------------------------------------- On Lis. 15, 2016, 7:58 dop., Jan Grulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129396/ > ----------------------------------------------------------- > > (Updated Lis. 15, 2016, 7:58 dop.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kservice > > > Description > ------- > > $SUMMARY says it all I guess, this patch allows to read > X-KDE-RunOnDiscreteGpu property which can be now set from KPropertiesDialog, > see review 129395. Also when running an application using KToolInvocation > (e.g. when running an app from panel or desktop) take this property into > account and set required variable accordingly. > > > Diffs > ----- > > src/kdeinit/ktoolinvocation.cpp c9eb922 > src/services/kservice.h 66525b4 > src/services/kservice.cpp 6574367 > > Diff: https://git.reviewboard.kde.org/r/129396/diff/ > > > Testing > ------- > > > Thanks, > > Jan Grulich > >
