----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129396/#review101130 -----------------------------------------------------------
src/kdeinit/ktoolinvocation.cpp (line 103) <https://git.reviewboard.kde.org/r/129396/#comment67777> I would say this doesn't belong here. This class is basically just a C++ API for the klauncher dbus api, which already has to lookup the KService anyway so it can read the new key while at it. - David Faure On Nov. 22, 2016, 12:11 p.m., Jan Grulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129396/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2016, 12:11 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kservice > > > Description > ------- > > $SUMMARY says it all I guess, this patch allows to read > X-KDE-RunOnDiscreteGpu property which can be now set from KPropertiesDialog, > see review 129395. Also when running an application using KToolInvocation > (e.g. when running an app from panel or desktop) take this property into > account and set required variable accordingly. > > > Diffs > ----- > > src/kdeinit/ktoolinvocation.cpp c9eb922 > src/services/kservice.h 66525b4 > src/services/kservice.cpp 6574367 > > Diff: https://git.reviewboard.kde.org/r/129396/diff/ > > > Testing > ------- > > > Thanks, > > Jan Grulich > >
