mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > installation.h:137 > QStringList installDownloadedFileAndUncompress(const > KNSCore::EntryInternal &entry, const QString &payloadfile, const QString > installdir); > - void runPostInstallationCommand(const QString &installPath); > + QProcess* runPostInstallationCommand(const QString &installPath); > BIC even if the api of this file is beyond terrible, unfortunately it's exported, so no binary incompatible changes should occur REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D4227 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks, leinir, whiting, mart
