mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > apol wrote in installation.h:137 > According to our BIC documentation: > https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B > > We can "remove private non-virtual functions if they are not called by any > inline functions (and have never been)." ha, i assumed also removing a private function was not ok.. ship it then REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D4227 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks, leinir, whiting, mart
