fvogt requested changes to this revision.
fvogt added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kfilewidget.h:150
>       */
>      void setSelection(const QString &name);
>  

This function only works correctly for URLs, as filenames can contain ':'s.
However, for those setSelectedUrl is the right function, so I'd mark this
function as deprecated

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D4937

To: dfaure, fvogt
Cc: fvogt, #frameworks

Reply via email to