fvogt added inline comments. INLINE COMMENTS
> dfaure wrote in kfilewidget.h:150 > Very good point. > > But there might be other users of this class who need the ability to select > by filename. > I think this means we have two options: > > - changing setSelection to only handle filenames, including those with a ':' > (bad, not backwards compatible) > - adding a setSelectedFileName(const QString &fileName), and then we can > deprecated setSelection(QString). Currently that works with setSelectedUrl as well as it handles relative urls (basically escaped filenames) as well, but it would definitely be a good shortcut, so I'm for option #2 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D4937 To: dfaure, fvogt Cc: fvogt, #frameworks
