eliasp added inline comments. INLINE COMMENTS
> file.h:107 > + }; > + bool execWithRoot(const QString &action, const QString &subAction, const > QVariant &args, PriviledgeWarning warning); > + void endPriviledgeOp(); I find `execWithRoot()` to be a bit misleading, as the goal shouldn't be to always elevate to `root`'s privileges but to only what's required to execute the specific operation (e.g. browse `/home/someotheruser` doesn't need `root`'s privileges but only `someotheruser`'s privileges). Always elevating to root is IMHO by far too permissive. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6197 To: chinmoyr, elvisangelaccio, #frameworks Cc: eliasp, aacid
