dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > jobuidelegateextension.h:230 > + */ > + virtual bool askPrivilegeOpConfirmation(const QList<QUrl> &urls, > PrivilegeConfType privilegeConfType) = 0; > /** This class is public, adding virtual methods is BIC. You have to make a V2 class that inherits from this one (with a KF6 TODO to merge them), or a completely separate class that's specific to privileged operations. Remember to add @since 5.37 to the class. > file_unix.cpp:684 > + // situation appear as if 'execWithRoot' method has been called for > the second time > + // within the the threshold time which means a warning must be shown > instead of an > + // authentication dialog. s/the the/the/ > helper.h:29 > + > +class Helper : public QObject > +{ Best class ever. Add a comment to explain what it does? (not much, AFAICS....) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6197 To: chinmoyr, elvisangelaccio, #frameworks, dfaure Cc: dfaure, eliasp, aacid