mlaurent added inline comments.

INLINE COMMENTS

> kossebau wrote in knewpasswordwidget.ui:88
> rather extends QWidget now? unsure what exactly the consequences are

The consequence is that we don't see it in designer :)
So why not but it's better to show a lineedit no ?

> kossebau wrote in kpasswordlineedit.h:6
> Should this not be rather lgpl2_+_?
> see https://community.kde.org/Policies/Licensing_Policy

I copied same license as knewpasswordwidget so I think it was ok.
So license is not the same in all kwidgetaddons ?

REVISION DETAIL
  https://phabricator.kde.org/D7011

To: mlaurent, cfeck, dfaure, elvisangelaccio
Cc: kossebau, elvisangelaccio, #frameworks

Reply via email to