mlaurent marked 3 inline comments as done. mlaurent added inline comments. INLINE COMMENTS
> cfeck wrote in knewpasswordwidget.cpp:118 > Can you double-check this change? To me, the echoMode() checks are now > reversed compared to the original code. > > I have not tested the code yet :) Nope it's ok as code is called after changing echomode I created an autotest for testing it REVISION DETAIL https://phabricator.kde.org/D7011 To: mlaurent, cfeck, dfaure, elvisangelaccio Cc: kossebau, elvisangelaccio, #frameworks
