dfaure added inline comments. INLINE COMMENTS
> dvratil wrote in kfileplacesmodel.cpp:153 > typo: `withBaloo` Minor: QLatin1String("true") is enough for a comparison (no need to use a 16-bit-per-char string) > kfileplacesview.cpp:1350 > + qWarning() << "Invalid search url:" << url; > + Q_ASSERT(false); > + } So if I, as a user, manually add "search:/doesnotexist" as a bookmark in the places view, the application asserts and dies? If I'm right, then this doesn't seem wise. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, ervin, mlaurent, dfaure Cc: dfaure, ervin, usta, mlaurent, dvratil, ngraham, #frameworks