mwolff added a comment.
lgtm, one minor nit, potentially for the future
INLINE COMMENTS
> kfileplacesmodel.cpp:967
>
> +bool KFilePlacesModel::Private::isFileIndexingEnabled() const
> +{
this could/should be a free function, not a member, considering its result is
cached in a member variable
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham,
ervin, mlaurent, dfaure
Cc: mwolff, dfaure, ervin, usta, mlaurent, dvratil, ngraham, #frameworks
