dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed.
I like the use of the 3-args QUrl::fromUserInput, I added it to Qt for such purposes. I don't like the hardcoded QDir::homePath(), this has to be done better... In KUrlNavigator it could be a setter. In KUriFilter, I would rather not do it there, but handle that in the caller, if possible? INLINE COMMENTS > kurlnavigatortest.cpp:216 > > + m_navigator->setHomeUrl(QDir::homePath()); > m_navigator->setLocationUrl(QUrl()); Does this line have any effect? This is only for the "go home" functionality, says the API docs, not for resolving relative paths, right? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8920 To: emateli, #frameworks, dfaure Cc: #frameworks
