cgiboudeaux added inline comments.

INLINE COMMENTS

> KDEInstallDirs.cmake:700-704
> +export XDG_DATA_DIRS=${KDE_INSTALL_FULL_DATADIR}:$XDG_DATA_DIRS
> +export XDG_CONFIG_DIRS=${KDE_INSTALL_FULL_CONFDIR}:$XDG_CONFIG_DIRS
> +export PATH=${KDE_INSTALL_FULL_BINDIR}:$PATH
> +export QT_PLUGIN_PATH=${KDE_INSTALL_FULL_QTPLUGINDIR}:$QT_PLUGIN_PATH
> +export QML2_IMPORT_PATH=${KDE_INSTALL_FULL_QMLDIR}:$QML2_IMPORT_PATH

missing LD_LIBRARY_PATH ?

> KDEInstallDirs.cmake:707
> +
> +    install(FILES ${CMAKE_BINARY_DIR}/prefix.sh DESTINATION 
> ${CMAKE_INSTALL_PREFIX})
> +endif()

I'm not sure that's the right location. my installation prefixes only contains 
subdirectories.
This file will also be overwritten if several modules turn the option on (which 
is an issue for distributions if they decide to enable the feature)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D9299

To: apol, #frameworks
Cc: cgiboudeaux, #build_system

Reply via email to