mlaurent added inline comments. INLINE COMMENTS
> desktoptojsontest.cpp:84 > QByteArray input = > - // include an insignificant group > - "[Some Group]\n" > - "Foo=Bar\n" > - "\n" > - "[Desktop Entry]\n" > - // only data inside [Desktop Entry] should be included > - "Name=Example\n" > - //empty lines > - "\n" > - " \n" > - // make sure translations are included: > - "Name[de_DE]=Beispiel\n" > - // ignore comments: > - "#Comment=Comment\n" > - " #Comment=Comment\n" > - "Categories=foo;bar;a\\;b\n" > - // As the case is significant, the keys Name and NAME are not > equivalent: > - "CaseSensitive=ABC\n" > - "CASESENSITIVE=abc\n" > - // Space before and after the equals sign should be ignored: > - "SpacesBeforeEq =foo\n" > - "SpacesAfterEq= foo\n" > - // Space before and after the equals sign should be ignored; the = > sign is the actual delimiter. > - // TODO: error in spec (spaces before and after the key??) > - " SpacesBeforeKey=foo\n" > - "SpacesAfterKey =foo\n" > - // ignore trailing spaces > - "TrailingSpaces=foo \n" > - // However spaces in the value are significant: > - "SpacesInValue=Hello, World!\n" > - // The escape sequences \s, \n, \t, \r, and \\ are supported for > values of > - // type string and localestring, meaning ASCII space, newline, tab, > - // carriage return, and backslash, respectively: > - "EscapeSequences=So\\sme esc\\nap\\te se\\\\qu\\re\\\\nces\n" // > make sure that the last n is a literal n not a newline! > - // the standard keys that are used by plugins, make sure correct > types are used: > - "X-KDE-PluginInfo-Category=Examples\n" // string key > - "X-KDE-PluginInfo-Version=1.0\n" > - // The multiple values should be separated by a semicolon and the > value of the key > - // may be optionally terminated by a semicolon. Trailing empty > strings must always > - // be terminated with a semicolon. Semicolons in these values need > to be escaped using \;. > - "X-KDE-PluginInfo-Depends=foo,bar,esc\\,aped\n" // string list > key > - "X-KDE-ServiceTypes=\n" // empty string list > - "X-KDE-PluginInfo-EnabledByDefault=true\n" // bool key > - // now start a new group > - "[New Group]\n" > - "InWrongGroup=true\n"; > + // include an insignificant group > + "[Some Group]\n" not necessary to change indentation in this patch. > desktoptojsontest.cpp:167 > QByteArray kdevInput = > - "[Desktop Entry]\n" > - "Type = Service\n" > - "Icon=text-x-c++src\n" > - "Exec=blubb\n" > - "Comment=C/C++ Language Support\n" > - "Comment[fr]=Prise en charge du langage C/C++\n" > - "Comment[it]=Supporto al linguaggio C/C++\n" > - "Name=C++ Support\n" > - "Name[fi]=C++-tuki\n" > - "Name[fr]=Prise en charge du C++\n" > - "GenericName=Language Support\n" > - "GenericName[sl]=Podpora jeziku\n" > - "ServiceTypes=KDevelop/NonExistentPlugin\n" > - "X-KDE-Library=kdevcpplanguagesupport\n" > - "X-KDE-PluginInfo-Name=kdevcppsupport\n" > - "X-KDE-PluginInfo-Category=Language Support\n" > - "X-KDevelop-Version=1\n" > - "X-KDevelop-Language=C++\n" > - "X-KDevelop-Args=CPP\n" > - "X-KDevelop-Interfaces=ILanguageSupport\n" > - > "X-KDevelop-SupportedMimeTypes=text/x-chdr,text/x-c++hdr,text/x-csrc,text/x-c++src\n" > - "X-KDevelop-Mode=NoGUI\n" > - "X-KDevelop-LoadMode=AlwaysOn"; > + "[Desktop Entry]\n" > + "Type = Service\n" don't change indent please > kaboutdatatest.cpp:184 > QLatin1String("copyright"), QLatin1String("hello world"), > - "http://www.koffice.org"); > + QString::fromLatin1("http://www.koffice.org")); > QCOMPARE(data.organizationDomain(), QString::fromLatin1("koffice.org")); QStringLiteral doen't work here ? > kprocesstest.cpp:93 > + p.setShellCommand(QStringLiteral("true || false")); > + QCOMPARE(p.program(), QStringList() << QString::fromLatin1("/bin/sh") << > QString::fromLatin1("-c") > + << QString::fromLatin1("true || false")); QStringLiteral REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: #frameworks