velurimithun added inline comments.
INLINE COMMENTS
> mlaurent wrote in kprocesstest.cpp:93
> ?
> QStringLiteral works fine with QStringList
Yeah working!!, I changed it!!
But, Unable to eliminate this compile error
> kstringhandlertest.cpp:45
> + expected << QLatin1String("kparts") << QLatin1String("reaches") <<
> QLatin1String("the parts other parts can't");
> + QCOMPARE(KStringHandler::perlSplit(QLatin1String(" "),
> + QLatin1String("kparts reaches the
> parts other parts can't"), 3), expected);
Here char i. e., (' ') is converted into string i.e., (" ") and then
QLatin1String is applied.
Since, we can't convert char into QLatin1String
> kstringhandlertest.cpp:76
> QTest::newRow("underscores") << "foo_bar_baz"
> - << QString("foo_" + zwsp + "bar_" + zwsp +
> "baz");
> + << QString(QStringLiteral("foo_") +
> QString(zwsp) + QStringLiteral("bar_") + QString(zwsp) +
> QStringLiteral("baz"));
>
Here too **zwsp** was QChar, it is converted into QString.
Same for below lines also!!
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: #frameworks
