Hey, @Volker: Is there a need to rush releasing KHolidays it under frameworks?
As far I see it, the include mechanism do not change find_package do not need to change and also the target_libraries do not need to changed also the API is fixed so far -> no changes in kdepim needed. The only thing that changes is the big bump of the version number and there will be some BIC cleanup, so there will be BIC breakage with that move. Distributions need to rebuild everything against the new framework. With only BIC changes there should be no big issue for distributions to ship a uptodate kdepim (17.12.X) with a uptodate KDE frameworks. sandro PS: please also inform distributi...@kde.org, if the switch has a fixed date. On Sonntag, 14. Januar 2018 15:59:46 CET Allen Winter wrote: > I don't object to making KHolidays a framework. > I kinda object to the short timeline. > > I wanted to finish up some BIC cleaning. No API changes planned at this > time. I'll try to hurry. > > On Sunday, January 14, 2018 4:20:38 AM EST Volker Krause wrote: > > On Tuesday, 6 September 2016 12:03:15 CET Volker Krause wrote: > > > On Friday 01 January 2016 18:24:17 David Faure wrote: > > > > On Thursday 24 December 2015 12:28:13 John Layt wrote: > > > > > Hi, > > > > > > > > > > It's xmas holidays, so it must be time to poke a stick at KHolidays > > > > > again > > > > > for inclusion as a Framework. As far as I am aware there are no > > > > > outstanding > > > > > porting issues with KHolidays and it is ready for review to be > > > > > included > > > > > as > > > > > a Tier 1 Framework in the next possible release. What's the next > > > > > step? > > > > > > > > Please make sure it passes all of the items in this checklist > > > > https://community.kde.org/Frameworks/CreationGuidelines > > > > > > AFAICS this is followed, apart from using the KF5 version number and > > > actually being marked as a framework, which I guess is pending framework > > > approval. > > > > This got lost somehow, any objection to executing the move to frameworks > > for 5.43, say end of this week? > > > > Regards, > > Volker
signature.asc
Description: This is a digitally signed message part.