I'm wrong. the changes are BC since I'm just moving static functions around. Moving KHolidays anytime you want is fine with me.
On Sunday, January 14, 2018 2:02:48 PM EST Volker Krause wrote: > On Sunday, 14 January 2018 16:50:08 CET Sandro Knauß wrote: > > @Volker: Is there a need to rush releasing KHolidays it under frameworks? > > this request is pending since more than 24 month, not exactly my definition > of > rushing things ;-) > > We should do the move reasonably early before the next application release > IMHO, so we don't collide with the pre-releases there. Apart from that I > don't > see any particular timing constraints. > > > As far I see it, the include mechanism do not change find_package do not > > need to change and also the target_libraries do not need to changed also > > the API is fixed so far -> no changes in kdepim needed. > > Exactly, it's all ready to go since two years. > > > The only thing that > > changes is the big bump of the version number and there will be some BIC > > cleanup, so there will be BIC breakage with that move. Distributions need > > to rebuild everything against the new framework. With only BIC changes > > there should be no big issue for distributions to ship a uptodate kdepim > > (17.12.X) with a uptodate KDE frameworks. > > Which BIC changes do you have in mind? The ABI has been stable since August > 2015 from what I can see. > > Regards, > Volker > > > PS: please also inform distributi...@kde.org, if the switch has a fixed > > date. > > On Sonntag, 14. Januar 2018 15:59:46 CET Allen Winter wrote: > > > I don't object to making KHolidays a framework. > > > I kinda object to the short timeline. > > > > > > I wanted to finish up some BIC cleaning. No API changes planned at this > > > time. I'll try to hurry. > > > > > > On Sunday, January 14, 2018 4:20:38 AM EST Volker Krause wrote: > > > > On Tuesday, 6 September 2016 12:03:15 CET Volker Krause wrote: > > > > > On Friday 01 January 2016 18:24:17 David Faure wrote: > > > > > > On Thursday 24 December 2015 12:28:13 John Layt wrote: > > > > > > > Hi, > > > > > > > > > > > > > > It's xmas holidays, so it must be time to poke a stick at > > > > > > > KHolidays > > > > > > > again > > > > > > > for inclusion as a Framework. As far as I am aware there are no > > > > > > > outstanding > > > > > > > porting issues with KHolidays and it is ready for review to be > > > > > > > included > > > > > > > as > > > > > > > a Tier 1 Framework in the next possible release. What's the next > > > > > > > step? > > > > > > > > > > > > Please make sure it passes all of the items in this checklist > > > > > > https://community.kde.org/Frameworks/CreationGuidelines > > > > > > > > > > AFAICS this is followed, apart from using the KF5 version number and > > > > > actually being marked as a framework, which I guess is pending > > > > > framework > > > > > approval. > > > > > > > > This got lost somehow, any objection to executing the move to frameworks > > > > for 5.43, say end of this week? > > > > > > > > Regards, > > > > Volker -- Allen Winter | allen.win...@kdab.com | Senior Software Engineer KDAB (USA) LLC, a KDAB Group company Tel. USA +1-866-777-KDAB(5322) ext3 KDAB - The Qt, C++ and OpenGL Experts
smime.p7s
Description: S/MIME cryptographic signature