mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.
You still forgot to launch autotest...
see:
"laurent@linux-5nvn:/compile/kde5/framework/frameworks/kcoreaddons/build>
./bin/kaboutdatatest
- Start testing of KAboutDataTest *********
Config: Using QtTest library 5.10.1, Qt 5.10.1 (x86_64-little_endian-lp64
shared (dynamic) release build; by GCC 7.2.1 20171020 [gcc-7-branch revision
253932])
PASS : KAboutDataTest::initTestCase()
PASS : KAboutDataTest::testLongFormConstructorWithDefaults()
PASS : KAboutDataTest::testLongFormConstructor()
PASS : KAboutDataTest::testShortFormConstructor()
FAIL! : KAboutDataTest::testSetAddLicense() Compared values are not the same
Actual (aboutData.licenses().at(2).text()): "free to write, reading
forbidden"
Expected (QLatin1String(LicenseFileText)) : "free to write, reading
forbidden, in the file"
Loc:
[/compile/kde5/framework/frameworks/kcoreaddons/autotests/kaboutdatatest.cpp(260)]
PASS : KAboutDataTest::testSetProgramIconName()
PASS : KAboutDataTest::testSetDesktopFileName()
PASS : KAboutDataTest::testCopying()
PASS : KAboutDataTest::testKAboutDataOrganizationDomain()
PASS : KAboutDataTest::testLicenseSPDXID()
PASS : KAboutDataTest::testLicenseOrLater()
PASS : KAboutDataTest::cleanupTestCase()
Totals: 11 passed, 1 failed, 0 skipped, 0 blacklisted, 3ms
"
> I found the porting error in line 260. Please compare you change in 260.
==========================================================================
You must launch autotest to see if you created a bug or not.
You need to compare before and after your patch and see if you have some
failed.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: dfaure, #frameworks
