mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.
When I try to compile your patch I have this compile error:
Do you are sure that you rebuild all ?
/compile/kde5/framework/frameworks/kcoreaddons/autotests/kaboutdatatest.cpp:
In member function ‘void KAboutDataTest::testLicenseSPDXID()’:
/compile/kde5/framework/frameworks/kcoreaddons/autotests/kaboutdatatest.cpp:330:91:
error: ‘QString::QString(const char*)’ is private within this context
QLatin1String(ShortDescription), KAboutLicense::GPL_V2);
^
In file included from /opt/qt5.10/include/QtCore/QString:1:0,
from /compile/kde5/framework/frameworks/kcoreaddons/src/lib/kaboutdata.h:30,
from
/compile/kde5/framework/frameworks/kcoreaddons/autotests/kaboutdatatest.cpp:21:
/opt/qt5.10/include/QtCore/qstring.h:818:5: note: declared private here
QString(const char *ch);
^~~~~~~
/compile/kde5/framework/frameworks/kcoreaddons/autotests/kaboutdatatest.cpp:330:91:
error: ‘QString::QString(const char*)’ is private within this context
QLatin1String(ShortDescription), KAboutLicense::GPL_V2);
^
In file included from /opt/qt5.10/include/QtCore/QString:1:0,
from /compile/kde5/framework/frameworks/kcoreaddons/src/lib/kaboutdata.h:30,
from
/compile/kde5/framework/frameworks/kcoreaddons/autotests/kaboutdatatest.cpp:21:
/opt/qt5.10/include/QtCore/qstring.h:818:5: note: declared private here
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: dfaure, #frameworks
