dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land.
Thanks, looks ok to me now. Well, all that code about incremental fetching (canFetchMore/fetchMore) only to then fetch everything upfront, could be simplified to just create the full tree without going through the fetchMore API... but I'll stop nitpicking ;) Please wait until the end of this weekend (5.43 tagging) before pushing though (new i18n calls). REPOSITORY R241 KIO BRANCH openwithdialog-filter-app-tree REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx Cc: rkflx, romangg, fabianr, abetts, ngraham, alexeymin, #frameworks, michaelh
