rkflx requested changes to this revision. rkflx added a comment. This revision now requires changes to proceed.
I rebased and was just about to land this, but found a serious problem: Accepting via OK, double clicking or [Enter] will only work if you have typed at least a single character. Otherwise nothing will happen and the dialog just stays open. Can anybody confirm? Perhaps related: The OK button does get enabled correctly after selecting an item. However, it does not get disabled again when selecting a category. Sounds like something is still off wrt. tracking what is actually selected.) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx Cc: rkflx, romangg, fabianr, abetts, ngraham, alexeymin, #frameworks, michaelh
