michaelh added inline comments. INLINE COMMENTS
> taglibextractortest.cpp:82 > > QCOMPARE(resultFlac.properties().value(Property::Title), > QVariant(QStringLiteral("Title"))); > QCOMPARE(resultFlac.properties().value(Property::Artist), > QVariant(QStringLiteral("Artist"))); Just a hint: The code would be easier to read if the title of the sample file was 'I love you so much' or 'Desaster will come' just not the same as the propery name. (Same for most of the props below) REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D10803 To: astippich, mgallien, ngraham Cc: vhanda, dfaure, michaelh, ngraham, #frameworks, ashaposhnikov, spoorun, nicolasfella, alexeymin