alexeymin added inline comments.

INLINE COMMENTS

> filemetadatawidgettest.cpp:60
> +    qputenv("PATH", qPrintable(QStringLiteral("%1;%2").arg(np).arg(op)));
> +    #endif
> +    const auto extractorPath = QDir( 
> QStringLiteral("%1/baloo_filemetadata_temp_extractor").arg(QFINDTESTDATA("../src"))).absolutePath();

Should probably use `QDir::listSeparator()` instead of this `#ifdef` logic

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D11882

To: michaelh, elvisangelaccio, #baloo, #frameworks
Cc: alexeymin, ashaposhnikov, astippich, spoorun

Reply via email to