alexeymin added a comment.

  Code looks fine, but I did not test if it actually works. ;)

INLINE COMMENTS

> filemetadatawidgettest.cpp:58
> +    const auto extractorPath = QDir( 
> QStringLiteral("%1/baloo_filemetadata_temp_extractor").arg(QFINDTESTDATA("../src"))).absolutePath();
> +    
> QCOMPARE(QStandardPaths::findExecutable(QStringLiteral("baloo_filemetadata_temp_extractor")),extractorPath);
>  

Missing space after comma?

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D11882

To: michaelh, elvisangelaccio, #baloo, #frameworks
Cc: alexeymin, ashaposhnikov, astippich, spoorun

Reply via email to