davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > abstractrunner_p.cpp:141 > + MatchReplyPrivate *p = new MatchReplyPrivate(this, message(), queryTerm); > + mActiveMatchReplies.append(p); > + you can't (and don't need to) keep a list here. It will break the MatchReply destructor calling submit working REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D10078 To: kossebau, broulik, davidedmundson Cc: bruns, michaelh, ngraham, #frameworks