kossebau added inline comments. INLINE COMMENTS
> davidedmundson wrote in abstractrunner_p.cpp:141 > you can't (and don't need to) keep a list here. > > It will break the MatchReply destructor calling submit working How would you think it does break? submit() tests if the reply is still valid, and only if it is then does create the d-bus message and also unregister from the runner instance. The runner itself uses this list to keep track of all active replies to cancel them if itself set to disabled or destructed (which might be corner-cases, but seems fine to have them covered). REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D10078 To: kossebau, broulik, davidedmundson Cc: bruns, michaelh, ngraham, #frameworks
