rkflx added a comment.
After sleeping over this, I don't feel comfortable the way this is supposed to work for single click: Selection markers only really make sense when enabling multi-select mode. Abusing a single selection marker in single-select mode to mean "put the filename in the line edit so it is editable" feels really weird, and if you are doing this more often than overwriting (which might be very likely!) hitting the small icon is quite cumbersome. IOW, I don't think the workaround which was promised to @jtamate's concern is good enough, and suggesting to switch to double click only to sustain a "pure" single click does not make sense to me either. The question for single click is: What is the primary action which should be triggered immediately? Is it overwriting, or is it putting the filename in the field? For Dolphin and the Open dialog it is clear that actually opening is the primary action. For Save I'd argue that overwriting is only the secondary option, and thus should be triggered by the second click only. I did some digging, and indeed this seems to be how it was originally implemented: 4ccd77256a0c <https://phabricator.kde.org/R446:4ccd77256a0c8277e57d2a210bad321fba9c2e7f> added what this patch is now trying to remove again. Then right after that, f729c291cdbb <https://phabricator.kde.org/R446:f729c291cdbb7154e431322d3b14516ee12610ea> allowed double clicking to overwrite without moving the mouse to the Save button. Somehow the latter commit got broken later on, I guess in 7f08f13809bc <https://phabricator.kde.org/R446:7f08f13809bc9bece921956dfd6fde20d1121246> ("Hope I didn't miss anything." haha). Maybe that slot should have triggered only for `KFileWidget::Saving`? Given the concerns with selection markers in single-select mode and thus for Save in general, and them being potentially far off in the future, can we think about changing this patch to double-click to overwrite, so single-click would still allow to append `_2` to the filename, a likely more common operation? Users who set click behaviour to double click everywhere would not be affected by this change at all! --- Historical side note: In KDE3 with single click enabled, the first click would select in file dialogs, the second click would accept. In KDE4 accepting was refined to single click for Open, but the double click was kept for Save, which makes sense to me. (And please think twice before making this discussion about a general single vs. double click debate again; I'm trying to improve single click to make more sense for the common use cases here, as we agreed upon as a sensible direction. Thanks ;) REPOSITORY R241 KIO BRANCH doubleclick_save (branched from master) REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg, ngraham Cc: rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns
