dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> udsentry.cpp:132
> + }
> + static void save(QDataStream &s, const UDSEntry &a)
> + {
strange that it's static, "a.d" could be this, if it wasn't static.
> udsentry.cpp:151
> + }
> + static void load(QDataStream &s, UDSEntry &a)
> + {
same
> udsentry.cpp:265
>
> - void insert(uint uds, const Field& field)
> + static void debugUDSEntry(QDebug stream, const KIO::UDSEntry &entry)
> {
should also not be static
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D12696
To: jtamate, dfaure, #frameworks
Cc: michaelh, ngraham, bruns
