bruns added inline comments. INLINE COMMENTS
> udsentry.cpp:132 > + } > + static void save(QDataStream &s, const UDSEntry &a) > + { Is there a reason to define the methods inside the class declaration? The diff would be significantly smaller if you kept the definition separate. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12696 To: jtamate, dfaure, #frameworks Cc: bruns, michaelh, ngraham