bruns added inline comments. INLINE COMMENTS
> bruns wrote in kfileitem.cpp:198 > Wouldn't it be better to call m_entry.clear() and m_entry.insert(...) here? > > For the call from the constructor, m_entry is empty, so you save the > std::find_if() in the replace method calls. > > For any other caller, is there any useful info in m_entry() which is still > valid when calling init() again? Ignore this one .. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12696 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, bruns, michaelh, ngraham
