ltoscano added a comment.
Looks fine by me, let's see if there are other comments. INLINE COMMENTS > KF5I18NMacros.cmake.in:138-139 > > - file(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/${dirname}) > - install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/${dirname} DESTINATION > ${destname}) > + file(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/${dirname}) > + install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/${dirname} DESTINATION > ${destname}) > + endif() I guess that those two lines are the critical parts (the call to file), but probably it's not bad to avoid processing other instructions too. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D12905 To: heikobecker, ilic Cc: ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns