heikobecker marked an inline comment as done. heikobecker added a comment.
Considering the feedback I'll probably merge this in a few days if no objections turn up in the meantime. INLINE COMMENTS > ltoscano wrote in KF5I18NMacros.cmake.in:138-139 > I guess that those two lines are the critical parts (the call to file), but > probably it's not bad to avoid processing other instructions too. Yes. And that was my thought as well and reason to move the rest inside the if REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D12905 To: heikobecker, ilic Cc: apol, ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns