broulik added a comment.
Thanks a lot for your patch!
I think it is cleaner if the button is setup but then hidden:
m_iconButton->setVisible(url.toString() != QLatin1String("trash:/"));
Curiously, Dolphin overwrites the icon whenever `url.protocol() == "trash`
whereas `KFilePlacesModel` only does it for `url.toString() == "trash:/"`.
However you cannot actually add files inside Trash to Places in Dolphin (and
why would you, you can from file dialog, though, but that is a bug) anyway.
So perhaps can be simplified even to:
m_iconButton->setVisible(url.scheme() != QLatin1String("trash"));
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14360
To: shubham, ngraham, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
