ngraham added a reviewer: Dolphin. ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > kfileplaceeditdialog.cpp:123 > m_iconButton = new KIconButton(this); > + m_iconButton->setVisible(url.scheme() != QLatin1String("trash")); > layout->addRow(i18n("Choose an &icon:"), m_iconButton); > m_iconButton->setObjectName(QStringLiteral("icon button")); Let's also avoid adding the button to the layout in this case, just like you're doing in D14378 <https://phabricator.kde.org/D14378>. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14360 To: shubham, ngraham, broulik, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns