elvisangelaccio added a comment. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel.
From a quick look, the architecture is sound and respects what was discussed in T9390 <https://phabricator.kde.org/T9390>. And indeed it works pretty well, awesome job @akrutzler! I'd even say this could already be shipped because it's better than what we currently ship. But I do have a few remarks: - It should be possible to generate the xml files using `qdbuscpp2xml`. And we should actually do that and copy the generated files in the `shared` folder (to be sure there aren't e.g. typos). - This diff contains some unrelated changes, which should be moved to different commits. For example, porting to the JSON protocol file, `#include` changes, etc. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15277 To: akrutzler, elvisangelaccio, ltoscano, hetzenecker Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp
