mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > mtpstorage.cpp:176 > + case LIBMTP_FILETYPE_UNDEF_AUDIO: > + return QStringLiteral(""); > + case LIBMTP_FILETYPE_WMV: QString() directly no ? > mtpstorage.cpp:188 > + case LIBMTP_FILETYPE_UNDEF_VIDEO: > + return QStringLiteral(""); > + case LIBMTP_FILETYPE_JPEG: Same > mtpstorage.cpp:240 > + case LIBMTP_FILETYPE_MHT: > + return QStringLiteral(""); > + case LIBMTP_FILETYPE_JP2: same > kmtpdinterface.h:42 > +public: > + KMTPDInterface(QObject *parent = nullptr); > + explicit REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15277 To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure, mlaurent Cc: mlaurent, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp