apol added a comment.
I guess the patch makes sense overall.
INLINE COMMENTS
> atticaprovider.cpp:277
> + for (const Content &content : contents) {
> + if (content.isValid()) {
> + if (checker.filterAccepts(content.tags())) {
Maybe it would be easier to read if we had a `if (!content.isValid()) continue;
...`.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D18813
To: leinir, #knewstuff
Cc: apol, kde-frameworks-devel, michaelh, ZrenBot, ngraham, bruns
