leinir marked an inline comment as done. leinir added inline comments. INLINE COMMENTS
> apol wrote in atticaprovider.cpp:277 > Maybe it would be easier to read if we had a `if (!content.isValid()) > continue; ...`. Hmm... the patch certainly would, i'll swap that around a bit. Generally don't like negations too much if i can avoid them, hunting exclamation marks just gets tiring after a while, but yeah, smaller patch is good anyway :) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D18813 To: leinir, #knewstuff Cc: apol, kde-frameworks-devel, michaelh, ZrenBot, ngraham, bruns
