ngraham added reviewers: broulik, Plasma, ngraham. ngraham added a comment.
Thanks very much for this, it looks great! This will land in 5.58 not 5.57 since we don't typically commit patches with string changes in the last two weeks before frameworks tagging (which happens in five days, see https://community.kde.org/Schedules/Frameworks). So please change all the `@since` tags. Thanks! REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D20181 To: JJRcop, broulik, #plasma, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns