apol added a comment.
In D20181#441918 <https://phabricator.kde.org/D20181#441918>, @JJRcop wrote: > In D20181#441887 <https://phabricator.kde.org/D20181#441887>, @aacid wrote: > > > Can we use https://api.kde.org/frameworks/kcoreaddons/html/classKFormat.html instead of doing this again? > > > I think that's out of scope for this patch. It should be done in another patch so we can refactor Frequency <https://phabricator.kde.org/source/kunitconversion/browse/master/src/frequency.cpp;99cfd52570b747e46d7657e1e11d2605b9a09b81$33> and Length <https://phabricator.kde.org/source/kunitconversion/browse/master/src/length.cpp;99cfd52570b747e46d7657e1e11d2605b9a09b81$33> to use KFormat as well. This can't be out of scope since as soon as you add it here we'll have to maintain API, so it can't actually be done as an iteration. Aleix REVISION DETAIL https://phabricator.kde.org/D20181 To: JJRcop, broulik, #plasma, ngraham Cc: apol, aacid, ngraham, kde-frameworks-devel, michaelh, bruns
