leinir added inline comments.

INLINE COMMENTS

> ngraham wrote in GridDelegate.qml:147
> This was a deliberate choice, to make sure that the delegate got selected 
> when one of its buttons got clicked. But yeah selected may not necessarily 
> require clicked, so maybe it wasn't the best way of doing it. If you can 
> think of a better way to ensure that, then by all means, please don't 
> hesitate to send a patch!

Right! That makes sense, yes - i'll try and work out if we can't get that done 
with a few less side effects :)

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik, GB_2, ndavis
Cc: leinir, Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, 
GB_2, kde-frameworks-devel, michaelh, ngraham

Reply via email to