bruns added inline comments.

INLINE COMMENTS

> sambausershareplugin.cpp:130
> +    connect(propertiesUi.sambaNameEdit, &QLineEdit::textChanged,
> +            this, &SambaUserSharePlugin::checkShareName);
> +    connect(propertiesUi.sambaAllowGuestChk, &QCheckBox::toggled,

I meant - do `setDirty()` in e.g. `checkShareName()`, i.e. only one connection 
per signal.

REPOSITORY
  R432 File Sharing (Samba) integration

REVISION DETAIL
  https://phabricator.kde.org/D21354

To: ngraham, #frameworks, apol
Cc: bruns, aacid

Reply via email to