ngraham added a comment.
In D21354#469531 <https://phabricator.kde.org/D21354#469531>, @bruns wrote: > LGTM > > currently, GCC thows some "0 for nullptr" and "missing override" warnings, are you going to address these (new SR)? > > Also, Qt recommends deriving from Q**Styled**ItemDelegate Yeah there are a lot of warnings and more code cleanup needed, this is just the first of many. :) REPOSITORY R432 File Sharing (Samba) integration REVISION DETAIL https://phabricator.kde.org/D21354 To: ngraham, #frameworks, apol Cc: bruns, aacid
