cullmann added inline comments. INLINE COMMENTS
> dhaumann wrote in kateview.cpp:2881 > Do we really need this call? Also Don't we miss setting the cursor position? > Incliding a begin/endEdit? I assume this is just copied from the normal void KTextEditor::ViewPrivate::keyReturn() { doc()->newLine(this); m_viewInternal->iconBorder()->updateForCursorLineChange(); m_viewInternal->updateView(); } ;=) In doubt I would just keep this as is and one can think separately if that is needed in both places. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22276 To: ahmadsamir, #ktexteditor, cullmann, dhaumann Cc: bruns, mickaelbo, kde-frameworks-devel, kwrite-devel, LeGast00n, domson, michaelh, ngraham, demsking, cullmann, sars, dhaumann