kossebau added inline comments. INLINE COMMENTS
> dfaure wrote in kactioncollection.h:278 > Does this work? It's a signal. Won't this only warn at emit time? (while > QT_MOC_COMPAT is what leads to a warning at connect time) > > Asking because you didn't do this in D24465 > <https://phabricator.kde.org/D24465> for the windowChanged() signals, so > something seems inconsistent. This being one of my experimental repos chance is I forgot to remove the KXMLGUI_DEPRECATED_VERSION here, and was blind when I checked the patch before uploading. Let me check again if the deprecated attribute actually gets triggered on memberfunction-pointer based connect, not sure right now, REPOSITORY R263 KXmlGui BRANCH deprecatedapi REVISION DETAIL https://phabricator.kde.org/D24466 To: kossebau, #frameworks, dfaure, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
