kossebau added a comment.
This falls into a category I also saw elsewhere doing all the patches, where the same API is used from two sides: the client side, like application code, and the serving side, like infrastructure. While we want to tell the client side, stop using this and for that also allow them to disable it, the serving side still needs to access it to support the legacy system. I had some ideas how to support this, though this would complicated all this fragile macro logic even more, so not sure this will work out. The other option is to remove the diabling wrappers around the programIconName API, so one can still use KF_DISABLE_DEPRECATED_BEFORE_AND_AT for the rests of the API. Actually I had done that in the other places where I came across that category. I would be in favour to do the same for programIconName. What do you think? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D24965 To: dfaure, kossebau, elvisangelaccio, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns