kossebau added inline comments.

INLINE COMMENTS

> kossebau wrote in kstandardaction_p.h:103
> Hm, KStandardShortcut::SaveOptions_DEPRECATED_DO_NOT_USE should not be needed 
> to be used here.
> Does the use of KF_DISABLE_DEPRECATED_BEFORE_AND_AT trigger this? If so, IMHO 
> ECMGenerateExportHeader needs to be fixed. Will have a look tomorrow latest.

Ah, KStandardShortcut is from KConfig. Though deprecated only at 5.39 as per 
API dox, so this would need another if/else... welcome to the deprecation 
jungle :)

I start to think that the *_BUILD_DEPRECATED_SINCE should just be limited to 
latest perhaps, given the size of KF modules and their interdependencies.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D24965

To: dfaure, kossebau, elvisangelaccio, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Reply via email to